Skip to content

fix(groups): toggle selection on meta-click#294

Merged
Antamansid merged 1 commit intomainfrom
fix_groups_selection
Apr 29, 2026
Merged

fix(groups): toggle selection on meta-click#294
Antamansid merged 1 commit intomainfrom
fix_groups_selection

Conversation

@Antamansid
Copy link
Copy Markdown
Collaborator

@Antamansid Antamansid commented Apr 29, 2026

Meta/ctrl-clicking an already-selected group did not deselect it because the click handler always passed selected = true to setSelection. The APPEND strategy with selected = true is a no-op for an already-selected id, so the click silently did nothing.

Mirror the Block click handler: pass !$selected.value when the meta key is held, so the group toggles on each ctrl/cmd-click.

Summary by Sourcery

Fix group selection behavior on canvas click events.

Bug Fixes:

  • Allow meta/ctrl-clicking an already-selected group to toggle its selection state instead of being a no-op.

Enhancements:

  • Extract the group click handling logic into a dedicated handler method for reuse and clarity.

@Antamansid Antamansid requested a review from draedful as a code owner April 29, 2026 08:04
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 29, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the group component click handling to use a dedicated handler that mirrors block-click behavior, enabling proper toggle selection on meta/ctrl-click by basing the selection flag on the current selected state when using the APPEND strategy.

File-Level Changes

Change Details Files
Add a dedicated click handler method on Group that toggles selection on meta/ctrl-click instead of always setting selected to true.
  • Replace inline click event listener in the Group constructor with a bound handleClick method.
  • In handleClick, stop event propagation and detect meta-key usage via isMetaKeyEvent.
  • When meta is not pressed, select the group with REPLACE strategy and selected=true.
  • When meta is pressed, call setSelection with selected inverted from the current $selected.value and APPEND strategy to allow toggling.
src/components/canvas/groups/Group.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The nested ternary in handleClick makes the selection logic harder to read; consider assigning selected and strategy to separate variables before calling setSelection to improve clarity.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The nested ternary in `handleClick` makes the selection logic harder to read; consider assigning `selected` and `strategy` to separate variables before calling `setSelection` to improve clarity.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@gravity-ui-bot
Copy link
Copy Markdown
Contributor

Preview is ready.

@Antamansid Antamansid merged commit 91371fb into main Apr 29, 2026
7 checks passed
@Antamansid Antamansid deleted the fix_groups_selection branch April 29, 2026 09:24
@gravity-ui gravity-ui Bot mentioned this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants