fix(groups): toggle selection on meta-click#294
Merged
Antamansid merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors the group component click handling to use a dedicated handler that mirrors block-click behavior, enabling proper toggle selection on meta/ctrl-click by basing the selection flag on the current selected state when using the APPEND strategy. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The nested ternary in
handleClickmakes the selection logic harder to read; consider assigningselectedandstrategyto separate variables before callingsetSelectionto improve clarity.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The nested ternary in `handleClick` makes the selection logic harder to read; consider assigning `selected` and `strategy` to separate variables before calling `setSelection` to improve clarity.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Preview is ready. |
draedful
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meta/ctrl-clicking an already-selected group did not deselect it because the click handler always passed
selected = truetosetSelection. The APPEND strategy withselected = trueis a no-op for an already-selected id, so the click silently did nothing.Mirror the Block click handler: pass
!$selected.valuewhen the meta key is held, so the group toggles on each ctrl/cmd-click.Summary by Sourcery
Fix group selection behavior on canvas click events.
Bug Fixes:
Enhancements: