-
Notifications
You must be signed in to change notification settings - Fork 31
feat: improvements for tabs removement #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3m1d0v
reviewed
Jan 20, 2023
src/extensions/yfm/YfmTabs/spec.ts
Outdated
| allowGapCursor: true, | ||
| attrs: {class: {default: 'unknown'}}, | ||
| content: 'yfm_tabs_list* yfm_tab_panel*', | ||
| content: 'yfm_tabs_list{1,} yfm_tab_panel{1,}', |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| content: 'yfm_tabs_list{1,} yfm_tab_panel{1,}', | |
| content: 'yfm_tabs_list yfm_tab_panel+', |
d3m1d0v
reviewed
Jan 20, 2023
src/extensions/yfm/YfmTabs/index.ts
Outdated
Comment on lines
78
to
89
| .addPlugin(() => | ||
| keymap({ | ||
| Backspace: tabPanelBackspace, | ||
| }), | ||
| ) | ||
| .addPlugin(() => | ||
| keymap({ | ||
| Backspace: tabBackspace, | ||
| }), | ||
| ); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| .addPlugin(() => | |
| keymap({ | |
| Backspace: tabPanelBackspace, | |
| }), | |
| ) | |
| .addPlugin(() => | |
| keymap({ | |
| Backspace: tabBackspace, | |
| }), | |
| ); | |
| .addKeymap(() => ({ | |
| Backspace: chainCommands(tabPanelBackspace, tabBackspace), | |
| })); |
0b52b82 to
0f85378
Compare
Contributor
|
Preview is ready. |
d3m1d0v
reviewed
Jan 20, 2023
Comment on lines
15
to
24
| const tabPanel = findParentNodeOfType(tabPanelType(state.schema))(state.selection); | ||
|
|
||
| if ( | ||
| tabPanel && | ||
| state.selection.from === tabPanel.pos + 2 && | ||
| state.selection.to === state.selection.from | ||
| ) { | ||
| return true; | ||
| } | ||
| return false; |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| const tabPanel = findParentNodeOfType(tabPanelType(state.schema))(state.selection); | |
| if ( | |
| tabPanel && | |
| state.selection.from === tabPanel.pos + 2 && | |
| state.selection.to === state.selection.from | |
| ) { | |
| return true; | |
| } | |
| return false; | |
| const $cursor = get$Cursor(state.selection); | |
| if($cursor?.node($cursor.depth - 1).type === tabPanelType(state.schema) && $cursor.start($cursor.depth - 1) === $cursor.pos - 1) { | |
| return true; | |
| } | |
| return false; |
0f85378 to
ebdca47
Compare
ebdca47 to
f21f6f5
Compare
d3m1d0v
approved these changes
Jan 25, 2023
makhnatkin
pushed a commit
that referenced
this pull request
May 28, 2024
feat: improvements for tabs removement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement for tabs removement behavior.
When user presses backspace in the beginning of tab title - it removes current tab and panel associated with it.
Also activating a tab next to it and panel associated with it