Skip to content

fix(view): setupRuntimeConfig is not a function on old html-extension peer #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
Merged

fix(view): setupRuntimeConfig is not a function on old html-extension peer #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8cd784
fix: upgrade html-extension peer-dep to support setupRuntimeConfig
Mar 17, 2025
310f7ad
fix: add setupRuntimeConfig optional chain because of old html-extens…
Mar 17, 2025
329d4ad
fix: add htmlRuntimeConfig info about html-extension version
Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/view/hocs/withYfmHtml/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export type WithYfmHtmlBlockOptions = {
export type WithYfmHtmlBlockProps = {
meta: TransformMeta;
yfmHtmlBlockConfig?: IHTMLIFrameElementConfig;
/** Works only with html-extension dep version 2.7.1 and higher */
htmlRuntimeConfig?: HTMLRuntimeConfig;
};

Expand Down
3 changes: 2 additions & 1 deletion src/view/hocs/withYfmHtml/useYfmHtmlBlockRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ export function useYfmHtmlBlockRuntime(
htmlRuntimeConfig: HTMLRuntimeConfig = {},
) {
if (meta?.script?.includes(runtime)) {
setupRuntimeConfig(htmlRuntimeConfig);
// MAJOR: update html-extension peer on ^2.7.1 and remove optional chain
setupRuntimeConfig?.(htmlRuntimeConfig);
import(/* webpackChunkName: "yfm-html-runtime" */ '@diplodoc/html-extension/runtime');
}
}
Loading