Skip to content

feat(mobileNavigation): added a parameter for the portal in mobile navigation #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025
Merged

feat(mobileNavigation): added a parameter for the portal in mobile navigation #1132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
694cd6d
feat(mobileNavigation): added a parameter for the portal in mobile na…
ReFFaT Feb 25, 2025
1605293
fix(stories): resolve conflicts
ReFFaT Feb 26, 2025
2a5dc37
fix(mobile-navigation): fixed component logic
ReFFaT Mar 3, 2025
6b73817
fix(navigation): updated props
ReFFaT Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/navigation/components/MobileNavigation/MobileNavigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export const MobileNavigation: React.FC<MobileNavigationProps> = ({
isOpened,
topItems,
bottomItems,
portalContainer,
...props
}) => {
const [isMounted, setIsMounted] = React.useState(false);
Expand All @@ -27,7 +28,7 @@ export const MobileNavigation: React.FC<MobileNavigationProps> = ({
}

return (
<Portal>
<Portal container={portalContainer?.current ?? undefined}>
<Foldable key={topItems?.length} className={b()} isOpened={Boolean(isOpened)}>
<div className={b('wrapper')}>
{topItems && (
Expand Down
9 changes: 8 additions & 1 deletion src/navigation/components/Navigation/Navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,15 @@ const b = block('navigation');
export interface NavigationComponentProps extends ClassNameProps {
logo: ThemedNavigationLogoData;
data: HeaderData;
mobilePortalContainer?: React.RefObject<HTMLElement>;
}

export const Navigation: React.FC<NavigationComponentProps> = ({data, logo, className}) => {
export const Navigation: React.FC<NavigationComponentProps> = ({
data,
logo,
className,
mobilePortalContainer,
}) => {
const {
leftItems,
rightItems,
Expand Down Expand Up @@ -56,6 +62,7 @@ export const Navigation: React.FC<NavigationComponentProps> = ({data, logo, clas
isOpened={isSidebarOpened}
activeItemId={activeItemId}
onActiveItemChange={onActiveItemChange}
portalContainer={mobilePortalContainer}
/>
</OutsideClick>
</nav>
Expand Down
1 change: 1 addition & 0 deletions src/navigation/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export interface MobileNavigationProps extends ClassNameProps, ActiveItemProps {
isOpened?: boolean;
topItems?: NavigationItemModel[];
bottomItems?: NavigationItemModel[];
portalContainer?: React.RefObject<HTMLElement>;
}

export interface NavigationProps extends MobileMenuButtonProps, ActiveItemProps {
Expand Down