Skip to content

fix(BasicCard): add target #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuberdysheva merged 2 commits into from
Feb 22, 2023
Merged

fix(BasicCard): add target #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ecf396
fix(BasicCard): add target
yuberdysheva Feb 22, 2023
e703e2b
fix: card params
yuberdysheva Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/models/constructor-items/sub-blocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ export interface BasicCardProps
Omit<ContentBlockProps, 'colSizes' | 'centered' | 'size' | 'theme'> {
url: string;
icon?: ImageProps;
target?: string;
}

export interface BannerCardProps {
Expand Down
4 changes: 2 additions & 2 deletions src/sub-blocks/BasicCard/BasicCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ import './BasicCard.scss';
const b = block('basic-card');

const BasicCard = (props: BasicCardProps) => {
const {url, title, text, border, icon, additionalInfo, links, buttons} = props;
const {title, text, icon, additionalInfo, links, buttons, ...cardParams} = props;
const iconProps = icon && getMediaImage(icon);

return (
<CardBase className={b()} url={url} border={border}>
<CardBase className={b()} {...cardParams}>
<CardBase.Content>
{iconProps && <Image {...iconProps} className={b('icon')} />}
<Content
Expand Down
2 changes: 1 addition & 1 deletion src/sub-blocks/BasicCard/__stories__/BasicCard.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default {

const DefaultTemplate: Story<BasicCardProps> = (args) => (
<div style={{maxWidth: '400px'}}>
<BasicCard {...args} />
<BasicCard {...args} target="_blank" />
</div>
);

Expand Down
4 changes: 4 additions & 0 deletions src/sub-blocks/BasicCard/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ export const BasicCard = {
type: 'string',
},
icon: ImageProps,
target: {
type: 'string',
enum: ['_blank', '_parent', '_top', '_self'],
},
},
},
};