Skip to content

fix: add uniqueness to children key prop #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niktverd merged 1 commit into from
Mar 2, 2023
Merged

fix: add uniqueness to children key prop #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/containers/PageConstructor/components/ConstructorBlocks/ConstructorBlocks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const ConstructorBlocks = ({items, shouldRenderBlock}: ConstructorBlocksP
let itemElement;
const key = getBlockKey(item, index);
const blockId = parentId ? `${parentId}_${key}` : key;
if (shouldRenderBlock && !shouldRenderBlock(item, key)) {
if (shouldRenderBlock && !shouldRenderBlock(item, blockId)) {
return null;
}

Expand All @@ -44,8 +44,8 @@ export const ConstructorBlocks = ({items, shouldRenderBlock}: ConstructorBlocksP
itemElement = (
<ConstructorLoadable
block={item}
key={key}
blockKey={key}
key={blockId}
blockKey={blockId}
config={config}
serviceId={serviceId}
params={params}
Expand All @@ -58,7 +58,7 @@ export const ConstructorBlocks = ({items, shouldRenderBlock}: ConstructorBlocksP

itemElement = (
<BlockIdContext.Provider value={blockId}>
<ConstructorItem data={item} key={key}>
<ConstructorItem data={item} key={blockId}>
{children}
</ConstructorItem>
</BlockIdContext.Provider>
Expand Down