feat(navigation): add prop withBorder by default #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
yuberdysheva
force-pushed
the
yuberdysheva/navigation-without-border
branch
from
42fe2d7 to
869f9af
Compare
aeksandla
reviewed
Jun 1, 2023
| component: PageConstructor, | ||
| } as Meta; | ||
|
|
||
| const DefaultTemplate: Story<PageConstructorProps> = (args) => <PageConstructor {...args} />; |
Collaborator
There was a problem hiding this comment.
If this story is about navigation, then maybe you need to show the navigation's props only, and make the rest of the page unchanged?
const DefaultTemplate: Story<NavigatinProps> = (args) => <PageConstructor {..._.omit(data, 'navigation')} {...args} />;
for example:
DefaultNavigation.args = data.navigation as NavigationProps;
aeksandla
approved these changes
Jun 1, 2023
yuberdysheva
pushed a commit
that referenced
this pull request
Jun 9, 2023
yuberdysheva
pushed a commit
that referenced
this pull request
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.