fix: navigation import and types #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
gorgeousvlad
suggested changes
Dec 6, 2022
src/components/index.ts
Outdated
| export {default as Header} from './navigation/components/Header/Header'; | ||
| export * as Navigation from './navigation/components/index'; | ||
|
|
||
| export * from './navigation/components/index'; |
Contributor
There was a problem hiding this comment.
why do we need to export all navigation items from this file?
| const b = block('logo'); | ||
|
|
||
| export interface LogoProps extends NavigationLogo { | ||
| export interface LogoProps extends NavigationLogoProps { |
Contributor
There was a problem hiding this comment.
what is the difference between LogoProps and NavigationLogoProps, it adds a little mess
Contributor
Author
There was a problem hiding this comment.
LogoProps has className, rename NavigationLogoProps to NavigationLogoData
| logo: NavigationLogo; | ||
| data: HeaderData; | ||
| logo: NavigationLogoProps; | ||
| data: HeaderDataProps; |
Contributor
There was a problem hiding this comment.
usually we use props in naming for react components props. Try to use another naming
Contributor
Author
There was a problem hiding this comment.
Returned previous naming
| import { | ||
| NavigationItem as NavigationItemModel, | ||
| NavigationDropdownItem, | ||
| NavigationItemProps as NavigationItemModel, |
| import { | ||
| NavigationDropdownItem, | ||
| NavigationItem as NavigationItemModel, | ||
| NavigationDropdownItemProps, |
src/models/navigation.ts
Outdated
| } | ||
|
|
||
| export interface NavigationLinkItem extends NavigationItemBase { | ||
| export interface NavigationLinkItemProps extends NavigationItemBaseProps { |
Contributor
There was a problem hiding this comment.
try not to use props here - there are models for navigation data in config
gorgeousvlad
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.