Skip to content

Conversation

@Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Nov 7, 2025

No description provided.

@Raubzeug Raubzeug requested a review from ma-efremoff as a code owner November 7, 2025 13:31
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@ma-efremoff
Copy link
Collaborator

Can we add screenshot tests with a collapsed array/object?

@Raubzeug
Copy link
Contributor Author

Raubzeug commented Nov 7, 2025

Can we add screenshot tests with a collapsed array/object?

I've totally forgot - I wanted to add initiallyCollapsed prop. So, I did and, and added tests

level: number;
open?: BlockType;
close?: BlockType;
depth?: number;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand the field stores count of children. Isn't it more appropriate to name the field size/length?

@Raubzeug Raubzeug requested a review from ma-efremoff November 10, 2025 07:54
@Raubzeug Raubzeug merged commit 705eb95 into main Nov 11, 2025
3 checks passed
@Raubzeug Raubzeug deleted the container-size branch November 11, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants