Skip to content

Conversation

@spivurno
Copy link
Contributor

Can be used to count the number of Radio Button fields with a specific choice checked (e.g. "N/A").

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2105380160/42151/

Summary

Customer needed a way to count the number of times an "N/A" choice was selected across a number of Radio Button fields. @saifsultanc recently added support for counting specific choices to this snippet (#586) so it seemed like a natural extension to add support for Radio Buttons.

… the number of Radio Button fields with a specific choice checked (e.g. "N/A").
@spivurno spivurno requested a review from saifsultanc December 23, 2022 03:01
@spivurno spivurno changed the title Added support for counting Radio Button choices. gw-choice-counter.php: Added support for counting Radio Button choices. Dec 23, 2022
@github-actions
Copy link

github-actions bot commented Dec 23, 2022

Fails
🚫

Commit message 'Added support for counting Radio Button choices. Can be used to count the number of Radio Button fields with a specific choice checked (e.g. "N/A").' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion.

🚫

Commit message '~ Bumped version.' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion.

Generated by 🚫 dangerJS against e7f96d5

Copy link
Contributor

@saifsultanc saifsultanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Tested with the combination(s) of checkbox and radio fields.

Just needs that update on the commit messages and it looks good to merge.😄

@spivurno spivurno merged commit 3a8fb98 into master Dec 28, 2022
@spivurno spivurno deleted the dave/gw-choice-counter/add-radio-button-support branch December 28, 2022 17:12
spivurno added a commit that referenced this pull request Oct 7, 2023
…ces. (#598)

* Added support for counting Radio Button choices. Can be used to count the number of Radio Button fields with a specific choice checked (e.g. "N/A").

* ~ Bumped version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants