feat(check-store): add smoke-test action and use resolve-check-config#255
Merged
Conversation
3c8370d to
068a762
Compare
abb939e to
7064ca7
Compare
damienwebdev
added a commit
that referenced
this pull request
May 17, 2026
damienwebdev
added a commit
that referenced
this pull request
May 17, 2026
damienwebdev
added a commit
that referenced
this pull request
May 17, 2026
…ainst a specific container (#255)
damienwebdev
added a commit
that referenced
this pull request
May 17, 2026
damienwebdev
added a commit
that referenced
this pull request
May 17, 2026
Merged
970a0af to
19bd2f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
check-store.yamlrunsunit-testandcoding-standardagainst every supported Magento version produced bysupported-version. There is no smoke check, so a store can be lint-clean and unit-test-green yet still fail to boot. There is also no caller-facing knob to disable individual checks per-project.Fixes: N/A
What is the new behavior?
smoke-testjob tocheck-store.yamlthat:mysql,search,queue,cache,nginx,php-fpm) from the supported-version matrix.setup:installinside thephp-fpmservice container.nginxservice container against the installed Magento path.pageandgraphqlsmoke probes against the running store.resolve-check-configaction.compute_matrixnow emits a singleresolvedoutput (per-job filtered matrix) and every downstream job:fromJSON(...)['<job>'].enabled != false, so callers can disable a check by adding it to.github/check-store.json.strategy.matrixfromresolved['<job>'].matrix, which already has each entry'sservicesmap filtered to the tiers that job needs.docs/workflows/check-store.md:.github/check-store.json, including a$schema-referenced example for editor autocompletion / validation.resolve-check-configaction README for the full config surface.Does this PR introduce a breaking change?
check-store.yaml's public inputs and secrets are unchanged. The newsmoke-testjob runs by default; callers can opt out by adding{ "jobs": { "smoke-test": false } }to.github/check-store.json.Other information
setup-install,configure-service-nginx,smoke-test) are already onmain; the workflow pins them to@main.unit-testno longer spins up unused service containers — its matrix entries carryservices: {}.