Skip to content
This repository was archived by the owner on Apr 11, 2025. It is now read-only.

Conversation

@MateusDadalto
Copy link
Contributor

@MateusDadalto MateusDadalto commented Aug 3, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Build step has repeated code for each php image kind

Fixes: N/A

What is the new behavior?

Only one build and publish step and a new line in the php matrix that determines the php kind

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@MateusDadalto MateusDadalto marked this pull request as ready for review August 3, 2022 21:42
@damienwebdev damienwebdev merged commit 1f00d6b into master Aug 3, 2022
@damienwebdev damienwebdev deleted the php-cli branch August 3, 2022 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants