fix: trigger crates.io publish on tag push#76
Merged
Conversation
The release: published event does not fire for GitHub Releases created with GITHUB_TOKEN in Actions, so publish.yml has not run since v0.2.3 despite seven tagged releases. Switch to a tag-push trigger matching release.yml's pattern so cargo publish runs for every vX.Y.Z tag regardless of how the Release is created.
graykode
added a commit
that referenced
this pull request
Apr 24, 2026
## Summary The demo gifs and theme screenshots under `assets/` total ~13 MiB uncompressed, which exceeds crates.io's 10 MiB per-crate upload limit. This is why the manual `cargo publish` attempt after #76 failed with `413 Payload Too Large`. Exclude `assets/` from the cargo package and rewrite README image links to absolute `raw.githubusercontent.com` URLs, so: - the package ships at ~107 KiB compressed (well under the limit), - the README still renders images correctly both on GitHub and on crates.io. ## Verified - `cargo package --list` no longer includes any `assets/*` entries - `target/package/abtop-0.3.6.crate` is 107 KiB (was ~13 MiB) - All 11 README image references rewritten to absolute URLs in one sweep ## Follow-up Once this lands, 0.3.6 can be manually published to close the `0.2.3 → 0.3.7` gap (or we skip 0.3.6 on crates.io entirely and let #76's automation publish the next tag).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish.ymluseson: release: types: [published], but this event does not fire for GitHub Releases created with the defaultGITHUB_TOKENin Actions. Sincecargo-dist'srelease.ymlcreates Releases withGITHUB_TOKEN,publish.ymlhas not run since v0.2.3 — v0.3.0 through v0.3.6 all shipped binaries via GitHub Releases but never reached crates.io, leavingcargo install abtopstuck at 0.2.3.Switch to a tag-push trigger using the same pattern
release.ymluses. The two workflows run in parallel;cargo publishis independent of the GitHub Release so ordering doesn't matter.Test plan
v0.3.7and confirm both Release and Publish workflows trigger(0.3.6 will be manually published separately to close the gap.)