Small change to address spindle delay during tool change #680
Closed
andrewmarles wants to merge 1 commit intogrblHAL:masterfrom
Closed
Small change to address spindle delay during tool change #680andrewmarles wants to merge 1 commit intogrblHAL:masterfrom
andrewmarles wants to merge 1 commit intogrblHAL:masterfrom
Conversation
… is off and RPM is 0.
Contributor
|
Not sure I get this. What is the actual state change? And is it for a PWM spindle where enable is controlled by RPM?
|
Contributor
Author
|
Seems with vfd spindles the value field is nonzero even when the spindle is off. I had the same issue reading that field with the atc plug-in. |
Contributor
|
Oops, that is a bad one - there are other flags than on and ccw in the value. I'll add a function that checks only on and ccw. |
Contributor
Author
|
This seems resolved with latest core updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best way to fix this, but it looks like there is a disconcerting pause during semi-auto toolchanges when the spindle is off and the RPM is zero.