Skip to content

Session Hooks Improvements#5252

Merged
greenbonebot merged 3 commits intomainfrom
session-hooks
Apr 24, 2026
Merged

Session Hooks Improvements#5252
greenbonebot merged 3 commits intomainfrom
session-hooks

Conversation

@bjoernricks
Copy link
Copy Markdown
Contributor

What

  • Rename useUserSessionTimeout to useSessionTimeout
  • Use useSessionTimeout in useSessionTracker
  • Avoid unnecessary re-rendering when using useSessionTimeout

Why

Consistent naming of hooks regarding the session and single source of truth for the session information.

@bjoernricks bjoernricks requested a review from a team as a code owner April 24, 2026 07:59
@greenbonebot greenbonebot enabled auto-merge (rebase) April 24, 2026 07:59
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA ecd4aea.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Ensure that the renew session function is stable and doesn't change on
every render which can cause additional unnecessary re-renders
components using the useUserSessionHook.
@bjoernricks bjoernricks force-pushed the session-hooks branch 2 times, most recently from b52affe to 8081513 Compare April 24, 2026 09:01
Avoid duplicate code for session handling. The session handling will
change in future and therefore we need single sources of truth.
Use consistent name for all hooks related to the user session.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.75%. Comparing base (49b0df2) to head (ecd4aea).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5252      +/-   ##
==========================================
- Coverage   78.76%   78.75%   -0.01%     
==========================================
  Files        1193     1193              
  Lines       31291    31288       -3     
  Branches     9357     9397      +40     
==========================================
- Hits        24646    24642       -4     
- Misses       5961     5962       +1     
  Partials      684      684              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greenbonebot greenbonebot merged commit 5124199 into main Apr 24, 2026
27 checks passed
@greenbonebot greenbonebot deleted the session-hooks branch April 24, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants