Skip to content

Session and Timezone#5272

Merged
greenbonebot merged 7 commits into
mainfrom
session-and-login
May 6, 2026
Merged

Session and Timezone#5272
greenbonebot merged 7 commits into
mainfrom
session-and-login

Conversation

@bjoernricks
Copy link
Copy Markdown
Contributor

What

Session and Timezone

Remove timezone data from the redux store and use the session instead.

Why

Use the session as only source of truth for the timezone

References

Checklist

  • Tests

Allow to actually change and verify the state of the mocked session.
Get the timezone information from the session instead of the redux
store.
Replace accessing the redux store for the timezone with the
useUserTimezone hook.
The timezone is retrieved from the session now and not from the redux
store anymore.
Don't use the redux store anymore for setting and getting the timezone.
Setting the timezone is not used for this hook anymore.
The timezone is handled via the session directly now.
@bjoernricks bjoernricks requested a review from a team as a code owner May 6, 2026 10:30
@greenbonebot greenbonebot enabled auto-merge (rebase) May 6, 2026 10:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA dc6b609.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 88.46154% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.84%. Comparing base (8cabd83) to head (dc6b609).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/gmp/testing.ts 92.85% 2 Missing ⚠️
src/web/pages/tasks/TaskComponent.tsx 33.33% 2 Missing ⚠️
src/web/pages/user-settings/GeneralSettings.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5272   +/-   ##
=======================================
  Coverage   78.84%   78.84%           
=======================================
  Files        1203     1203           
  Lines       31439    31442    +3     
  Branches     9405     9447   +42     
=======================================
+ Hits        24787    24792    +5     
+ Misses       5967     5965    -2     
  Partials      685      685           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greenbonebot greenbonebot merged commit 2f47b3a into main May 6, 2026
27 checks passed
@greenbonebot greenbonebot deleted the session-and-login branch May 6, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants