Move Session from Settings to GMP object#5279
Merged
Merged
Conversation
Avoid code duplication for creating a storage object for testing purposes.
The session is not really a setting and therefore is should be available at the Gmp instance instead.
The session is now available on the Gmp instance directly.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
The session should not be used directly. Instead one of it's data hooks should be used which get re-rendered if a session value changes.
The session got moved from the settings directly to the gmp object.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5279 +/- ##
=======================================
Coverage 78.76% 78.76%
=======================================
Files 1211 1210 -1
Lines 31752 31754 +2
Branches 9509 9510 +1
=======================================
+ Hits 25008 25012 +4
+ Misses 6042 6040 -2
Partials 702 702 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daniele-mng
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move Session from Settings to GMP object
Why
The session is not really a setting. It's a global thing.
Checklist