Fix displaying errors if creating a credential in alert dialog fails#5301
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
bjoernricks
force-pushed
the
fix-alert-credential-create-errors
branch
from
76db3f0 to
0a7b9b6
Compare
daniele-mng
approved these changes
May 19, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5301 +/- ##
=======================================
Coverage 78.99% 79.00%
=======================================
Files 1216 1216
Lines 32074 32070 -4
Branches 9583 9543 -40
=======================================
- Hits 25337 25336 -1
+ Misses 6030 6027 -3
Partials 707 707 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Return a promise from the create credential function instead of passing the error as prop. The prop error was not forwarded to the SaveDialog.
bjoernricks
force-pushed
the
fix-alert-credential-create-errors
branch
from
0a7b9b6 to
df034ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix displaying errors if creating a credential in alert dialog fails
Why
Return a promise from the create credential function instead of passing the error as prop. The prop error was not forwarded to the SaveDialog.