Fix Schedule Dialog#5313
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
The component itself is already converted to TypeScript.
This issue got introduced with the session refactoring and shows again how important TypeScript can be for the whole application. Closes #5309
bjoernricks
force-pushed
the
fix-schedule-dialog
branch
from
6a6c881 to
fd3d81e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5313 +/- ##
==========================================
+ Coverage 79.08% 79.17% +0.09%
==========================================
Files 1222 1222
Lines 32207 32204 -3
Branches 9626 9624 -2
==========================================
+ Hits 25470 25498 +28
+ Misses 6030 6001 -29
+ Partials 707 705 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use TypeScript to catch possible type errors early.
Set labels to allow to find elements by role and label.
Ensure ScheduleComponent works and the dialog can be opened.
bjoernricks
force-pushed
the
fix-schedule-dialog
branch
from
fd3d81e to
df5d416
Compare
daniele-mng
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix Schedule Dialog
Why
Sadly my session refactoring did break the ScheduleDialog unnoticed. Therefore convert the ScheduleComponent to TypeScript to catch such type issues early in future.
References
#5309
https://jira.greenbone.net/browse/GEA-1807