Skip to content

Cleanup envelope#359

Merged
greenbonebot merged 5 commits intomainfrom
cleanup-envelope
Apr 2, 2026
Merged

Cleanup envelope#359
greenbonebot merged 5 commits intomainfrom
cleanup-envelope

Conversation

@bjoernricks
Copy link
Copy Markdown
Contributor

What

Cleanup envelope and remove unused data

Why

Remove unused data from structs, reduce number of functions and safe some bytes for every gsad response.

The backend operation is not used in GSA therefore it can be removed
safely.
The role is not used in GSA therefore it can safely be removed.
The vendor version is set via a setting in GSA and not used for gsad
anymore.
This is a leftover from old XLST based GSA times and can be safely
removed because it's not used in current GSA.
The time data is unused and therefore can be safely removed.
@bjoernricks bjoernricks requested review from a team as code owners April 2, 2026 08:54
@greenbonebot greenbonebot enabled auto-merge (rebase) April 2, 2026 08:54
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.74%. Comparing base (a1e5feb) to head (0b3ac9c).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/gsad_gmp.c 0.00% 3 Missing ⚠️
src/gsad_http.c 0.00% 1 Missing ⚠️
src/gsad_user.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   31.00%   30.74%   -0.26%     
==========================================
  Files          30       30              
  Lines       11348    11265      -83     
  Branches      995      994       -1     
==========================================
- Hits         3518     3463      -55     
+ Misses       7771     7743      -28     
  Partials       59       59              
Flag Coverage Δ
unittests 30.74% <16.66%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@greenbonebot greenbonebot merged commit 7f1d8d4 into main Apr 2, 2026
19 of 21 checks passed
@greenbonebot greenbonebot deleted the cleanup-envelope branch April 2, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants