Skip to content

Remove --mlisten and --mport arguments#366

Merged
bjoernricks merged 1 commit intomainfrom
unix-socket-gmp-only
Apr 7, 2026
Merged

Remove --mlisten and --mport arguments#366
bjoernricks merged 1 commit intomainfrom
unix-socket-gmp-only

Conversation

@bjoernricks
Copy link
Copy Markdown
Contributor

@bjoernricks bjoernricks commented Apr 7, 2026

What

Remove --mlisten and --mport arguments

Why

Drop support for connecting to gvmd via TLS. Only the unix socket connection is supported now. This makes the code more simple and easier to read. The TLS connection in gvmd is still available but not maintained anymore since a while.

@bjoernricks bjoernricks requested review from a team as code owners April 7, 2026 12:48
@bjoernricks bjoernricks enabled auto-merge (rebase) April 7, 2026 12:48
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.36%. Comparing base (540a886) to head (9a1ac45).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   94.49%   94.36%   -0.13%     
==========================================
  Files          24       24              
  Lines        3940     3851      -89     
  Branches       80       80              
==========================================
- Hits         3723     3634      -89     
  Misses        179      179              
  Partials       38       38              
Flag Coverage Δ
unittests 94.36% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bjoernricks bjoernricks force-pushed the unix-socket-gmp-only branch from 504a6b9 to 8776972 Compare April 7, 2026 12:52
Drop support for connecting to gvmd via TLS. Only the unix socket
connection is supported now. This makes the code more simple and easier
to read. The TLS connection in gvmd is still available but not maintained
anymore since a while.
@bjoernricks bjoernricks force-pushed the unix-socket-gmp-only branch from 8776972 to 9a1ac45 Compare April 7, 2026 13:06
@bjoernricks bjoernricks merged commit 7336e20 into main Apr 7, 2026
21 checks passed
@bjoernricks bjoernricks deleted the unix-socket-gmp-only branch April 7, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants