fix: Fix NULL xml passed to gsad_envelope in login#372
Merged
greenbonebot merged 2 commits intomainfrom Apr 10, 2026
Merged
Conversation
Login flow passed NULL as xml payload, which led to a GLib critical in g_string_append. Use an empty string instead.
bjoernricks
reviewed
Apr 10, 2026
ozgen
force-pushed
the
fix/gsad-null-xml-envelope
branch
from
aee0668 to
cd00342
Compare
bjoernricks
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix passing
NULLas XML payload togsad_envelopein the login flow.Why
The
loginflow passedNULLas the XML payload togsad_envelope(), whichresulted in a GLib critical (
g_string_appenddoes not acceptNULL).References
#369