Improve getting host from params for override and note#412
Merged
greenbonebot merged 1 commit intoMay 26, 2026
Conversation
Ensure we get the desired host data from the params when creating or updating overrides and notes. This is a bug in gsad 26.0.0 but already seems to be fixed in main due to refactoring of the exec_gmp function. Nevertheless be safe and ensure we get the expected host data without ever crashing. Closes #411
ozgen
approved these changes
May 26, 2026
greenbonebot
deleted the
ensure-override-and-note-host-is-parsed-correctly
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improve getting host from params for override and note
Why
Ensure we get the desired host data from the params when creating or updating overrides and notes. This is a bug in gsad 26.0.0 but already seems to be fixed in main due to refactoring of the exec_gmp function. Nevertheless be safe and ensure we get the expected host data without ever crashing.
References
https://jira.greenbone.net/browse/GEA-1808
#411