Skip to content

Conversation

@bjoernricks
Copy link
Contributor

No description provided.

Module variables should use upper letters.
The file needs to contain xml commands and must not be a gmp python
script. Therefore use xml ending in the example.
gvm_pyshell.py -> pyshell.py
gvm_cli.py -> cli.py
@bjoernricks bjoernricks requested a review from a team October 25, 2018 14:08
@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   16.13%   16.13%           
=======================================
  Files           7        7           
  Lines        2027     2027           
=======================================
  Hits          327      327           
  Misses       1700     1700
Impacted Files Coverage Δ
gmp/clients/pyshell.py 0% <0%> (ø)
gmp/clients/cli.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b022972...adf4336. Read the comment docs.

@bjoernricks bjoernricks merged commit fb83350 into greenbone:master Oct 25, 2018
@bjoernricks bjoernricks deleted the update-clients branch October 25, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants