Fixes the update-task-target script. #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernricks
approved these changes
Sep 23, 2019
Contributor
bjoernricks
left a comment
bjoernricks
left a comment
There was a problem hiding this comment.
Yes with Gmp7 you could pass make_unique=True which did that for you. We removed that option in Gmp8 because it cost to much extra code in gvmd.
bjoernricks
requested changes
Sep 23, 2019
Contributor
bjoernricks
left a comment
bjoernricks
left a comment
There was a problem hiding this comment.
A CHANGELOG.md entry should be added for this change too. E.g.
- Fixed update-task-target.script to create unique target names for GMP 8
bjoernricks
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems, that two targets can not have the same name (anymore (?)). The gmp responses that the Target already exists. This-why the copied target gets the suffix
_copy.Checklist: