Skip to content

Conversation

@jjnicola
Copy link
Member

@jjnicola jjnicola commented Aug 9, 2018

No description provided.

@jjnicola jjnicola requested review from a team, janowagner and rgrewe August 9, 2018 08:02
CHANGELOG.rst Outdated
* Allow anonymous connections
* Require lxml and defusedxml python modules
* Improve documentation
* Several code improvement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Several code improvements

Copy link
Member

@rgrewe rgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have changed a lot since the last release.
Wouldn't it be better to change the version to at least 1.4.0?

@bjoernricks
Copy link
Contributor

bjoernricks commented Aug 9, 2018

Would be nice if we use https://semver.org/

Only Bugfixes => Patch version change
Also API changes => Minor version change
API Breakage => Major version change

@jjnicola
Copy link
Member Author

jjnicola commented Aug 9, 2018

Set new release to 1.4.0.

@rgrewe rgrewe changed the title Update CHANGELOG and set release version to 1.3.2 Update CHANGELOG and set release version to 1.4.0 Aug 9, 2018
@bjoernricks bjoernricks self-requested a review August 9, 2018 09:31
@jjnicola jjnicola merged commit b359193 into greenbone:master Aug 9, 2018
@jjnicola jjnicola deleted the release branch August 9, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants