Change: only compile credential store code when needed#2802
Merged
greenbonebot merged 4 commits intomainfrom Mar 2, 2026
Merged
Change: only compile credential store code when needed#2802greenbonebot merged 4 commits intomainfrom
greenbonebot merged 4 commits intomainfrom
Conversation
mattmundell
force-pushed
the
stray-fns-cs
branch
from
1dc9d48 to
f0c7dfa
Compare
bjoernricks
approved these changes
Mar 2, 2026
This file is already behind an ENABLE_CREDENTIAL_STORES check in cmake, so these #ifs are redundant, they're always true.
These variables (credential_store_id etc) are only set in gmp.c when ENABLE_CREDENTIAL_STORES is true.
4 means that the feature is not enabled, which is always the case when credential stores are not compiled in. Also wrap the whole "cs_" type handling in a check, because that block is only used when the feature is enabled. I'm doing this to prevent the regular code from calling credential store functions when credential stores are not compiled in.
bjoernricks
force-pushed
the
stray-fns-cs
branch
from
f0c7dfa to
6404139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
These commits reduce the amount of credential store code that is compiled when
ENABLE_CREDENTIAL_STORESis true.See commit logs for rationales.
Why
This prevents many unused functions when
ENABLE_CREDENTIAL_STORESis 0.References
Follows /pull/2789.
Testing
cs_up, both with credential stores compiled in and compiled out