adds a workaround for inline svg and WeasyPrint#120
Merged
y0urself merged 3 commits intogreenbone:masterfrom Nov 26, 2020
nichtsfrei:add_inline_svg
Merged
adds a workaround for inline svg and WeasyPrint#120y0urself merged 3 commits intogreenbone:masterfrom nichtsfrei:add_inline_svg
y0urself merged 3 commits intogreenbone:masterfrom
nichtsfrei:add_inline_svg
Conversation
Unfortunately WeasyPrint does not support inline svg at all, since we need that functionality to create pictures dynamically based on report-formats. This workaround does look for tags with svg and then creates an img element with base64 image content of that. We are painfully aware that we lose css information with that method, but the conclusion is that it is better to may define design element twice (in the svg and in css) than to not have this possibility at all.
y0urself
approved these changes
Nov 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Unfortunately WeasyPrint does not support inline svg at all, since we
need that functionality to create pictures dynamically based on
report-formats.
This workaround does look for tags with svg and then creates an img
element with base64 image content of that.
We are painfully aware that we lose css information with that method,
but the conclusion is that it is better to may define design element twice
(in the svg and in css) than to not have this possibility at all.
Why:
How:
Create an pdf-report template with svg content in it. Create a pdf and verify that the svg is displayed.
Checklist: