Skip to content

set defaults to be useable for GOS#153

Merged
y0urself merged 2 commits intomasterfrom
senseable-defaults
Jan 6, 2021
Merged

set defaults to be useable for GOS#153
y0urself merged 2 commits intomasterfrom
senseable-defaults

Conversation

@nichtsfrei
Copy link
Member

The target environment GOS is using:

  • syslog
  • DEBUG should be false
  • ALLOWED_HOST should be * (actual control is done via nginx)

What:

Why:

How:

Checklist:

The target environment GOS is using:
- syslog
- DEBUG should be false
- ALLOWED_HOST should be * (actual control is done via nginx)
@nichtsfrei nichtsfrei requested a review from a team January 5, 2021 18:22
y0urself
y0urself previously approved these changes Jan 5, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #153 (126b51a) into master (2029d46) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   90.71%   90.87%   +0.15%     
==========================================
  Files          35       35              
  Lines        1260     1260              
==========================================
+ Hits         1143     1145       +2     
+ Misses        117      115       -2     
Impacted Files Coverage Δ
pheme/settings.py 93.33% <100.00%> (ø)
pheme/transformation/scanreport/renderer.py 81.51% <0.00%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2029d46...126b51a. Read the comment docs.

@y0urself y0urself merged commit cdb52c4 into master Jan 6, 2021
@nichtsfrei nichtsfrei deleted the senseable-defaults branch January 6, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants