move legend of charts from middle bottom to middle left#170
Merged
nichtsfrei merged 5 commits intogreenbone:masterfrom Feb 15, 2021
nichtsfrei:master
Merged
move legend of charts from middle bottom to middle left#170nichtsfrei merged 5 commits intogreenbone:masterfrom nichtsfrei:master
nichtsfrei merged 5 commits intogreenbone:masterfrom
nichtsfrei:master
Conversation
To implicitely verify that svg of charts is not broken it should be used within test_http_accept_visual.
Member
Author
|
ci can be found here: https://app.circleci.com/pipelines/github/nichtsfrei/pheme?branch=master |
y0urself
requested changes
Feb 14, 2021
y0urself
reviewed
Feb 14, 2021
y0urself
reviewed
Feb 14, 2021
y0urself
reviewed
Feb 14, 2021
Naming of variables in charts/__init__.py, documentation issue in build_legend. Remove unnecessary calculation within pie chart.
y0urself
approved these changes
Feb 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Move chart legend from bottom to left due to mockup changes.
Why:
How:
Checklist: