switch to json to hold all template information instead of loading single files#55
Merged
y0urself merged 7 commits intogreenbone:masterfrom Oct 13, 2020
nichtsfrei:report_format_editor_html_rendering
Merged
switch to json to hold all template information instead of loading single files#55y0urself merged 7 commits intogreenbone:masterfrom nichtsfrei:report_format_editor_html_rendering
y0urself merged 7 commits intogreenbone:masterfrom
nichtsfrei:report_format_editor_html_rendering
Conversation
nichtsfrei
changed the title
instead of using cover_image, logo files it is stored within a json and add new endpoint to manipulate global template parameters within that json.
y0urself
reviewed
Oct 13, 2020
|
|
||
| def measure_time(func): | ||
| def measure(*args, **kwargs): | ||
| startt = time.process_time() |
y0urself
approved these changes
Oct 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Add a small indicator to upload report and create_pdf to the report_format editor so that a user knows that something is happening in the background
Change from loading image files to a parameter.json file which holds all global design elements to make it easier to change them,
Add an endpoint to manipulate parameter.json
Why:
Unfortunately proceeding an xml and creating a pdf can take a while especially with a slower cpu.
Some parameter needs to be globally changeable within the standard template to make customization easier.
How:
Checklist: