Refactor: Replace enum_from_string() functions with Enum.from_string() functions#573
Merged
Refactor: Replace enum_from_string() functions with Enum.from_string() functions#573
enum_from_string() functions with Enum.from_string() functions#573Conversation
…ach it to the AlertCondition as a from_string() function.
y0urself
force-pushed
the
y0urself/from-string-at-enum
branch
from
47d7462 to
ee27041
Compare
Codecov Report
@@ Coverage Diff @@
## main #573 +/- ##
=======================================
Coverage 98.82% 98.83%
=======================================
Files 54 54
Lines 3923 3947 +24
Branches 934 934
=======================================
+ Hits 3877 3901 +24
Misses 34 34
Partials 12 12
Continue to review full report at Codecov.
|
y0urself
force-pushed
the
y0urself/from-string-at-enum
branch
from
cb1a424 to
ad6eaef
Compare
…Type into the Enums
…ype into the Enums
…el into the Enums
y0urself
force-pushed
the
y0urself/from-string-at-enum
branch
from
a13e0fd to
8a77b96
Compare
… HelpFormat and SortOrder into the Enums
y0urself
force-pushed
the
y0urself/from-string-at-enum
branch
from
8559125 to
a4bd399
Compare
…0urself/from-string-at-enum
bjoernricks
approved these changes
Oct 11, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Removing all
get_entity_type_from_string()methods and replace them byEntityType.from_string()classmethodsWhy:
Gmp.typesthrough this step.How:
@classmethodin theEnumto add methods to Enums ...Checklist: