Ensure that connection is closed when using context manager#660
Merged
bjoernricks merged 1 commit intomainfrom Jan 27, 2022
Merged
Ensure that connection is closed when using context manager#660bjoernricks merged 1 commit intomainfrom
bjoernricks merged 1 commit intomainfrom
Conversation
bjoernricks
force-pushed
the
disconnect-for-context-manager
branch
from
d0adfac to
696e135
Compare
y0urself
requested changes
Jan 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #660 +/- ##
==========================================
- Coverage 98.84% 98.81% -0.03%
==========================================
Files 55 55
Lines 3967 3970 +3
Branches 1025 1025
==========================================
+ Hits 3921 3923 +2
Misses 33 33
- Partials 13 14 +1
Continue to review full report at Codecov.
|
When using the context manager on the Gmp class which determines the supported GMP version ensure that the opened connection is closed when leaving the context. Fixes #659
bjoernricks
force-pushed
the
disconnect-for-context-manager
branch
from
696e135 to
46b0e4a
Compare
y0urself
approved these changes
Jan 27, 2022
bjoernricks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
When using the context manager on the Gmp class which determines the
supported GMP version ensure that the opened connection is closed when
leaving the context.
Fixes #659
Why:
Always close connections when using context manager.
How:
Checklist: