UNION scan of remainder looks too deep for parentheses#293
Merged
greenlion merged 3 commits intogreenlion:masterfrom Oct 1, 2020
Merged
UNION scan of remainder looks too deep for parentheses#293greenlion merged 3 commits intogreenlion:masterfrom
greenlion merged 3 commits intogreenlion:masterfrom
Conversation
greenlion
approved these changes
Dec 23, 2018
Owner
|
Can you investigate the test failures? |
greenlion
added a commit
that referenced
this pull request
Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An expression such as
SELECT * FROM SOFTWARE WHERE (DISPLAY_NAME like "a%") UNION ALL SELECT * FROM SOFTWARE WHERE (DISPLAY_NAME like "b%")Will fail, since the current logic will scan inside the sub-select, and extract whatever is inside the set of parentheses inside of it. My update modifies the logic to only look for a parenthesis in the very first nonempty token. The unit tests
tests/cases/parser/issue95Test.php, tests/cases/parser/unionTest.php, and tests/cases/creator/unionTest.php all run to completion with my change.
I would appreciate getting this fix in the codebase. Thank you for your help!