Configure hosts file when installing NRO version#49
Merged
comzeradd merged 1 commit intogreenpeace:mainfrom Dec 18, 2024
Merged
Configure hosts file when installing NRO version#49comzeradd merged 1 commit intogreenpeace:mainfrom
comzeradd merged 1 commit intogreenpeace:mainfrom
Conversation
Adds checking for hosts configuration in the nro:install script and adds it if missing.
Contributor
Author
|
Tested in my Ubuntu environment and it works as expected. Adds the lines to |
comzeradd
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds checking for hosts configuration in the nro:install script and adds it if missing.
Without this, the hosts file is not updated for NRO developers if they directly install their NRO version. The result is, that the website is not available locally from the domain
www.planet4.test.