Merged
Conversation
comzeradd
commented
Nov 28, 2025
| function wpenvCheck () { | ||
| const versionRequired = '9'; | ||
| const versionRequired = '10'; | ||
| const versionRunning = runWithOutput('npx wp-env --version').split('.')[0]; |
comzeradd
commented
Nov 28, 2025
| * Node version control | ||
| */ | ||
| console.log('Node version: ' + process.version); | ||
| nodeCheck(); |
Member
Author
There was a problem hiding this comment.
Removed the check from here, as we already do it in the env:requirements command
comzeradd
force-pushed
the
nro-install
branch
2 times, most recently
from
d997dfe to
933f091
Compare
comzeradd
commented
Nov 28, 2025
| nro:enable Enable installed NRO theme and database | ||
| nro:disable Switch back to default theme and database | ||
| nro:theme <?nro> Clone NRO theme in themes dir | ||
|
|
Member
Author
There was a problem hiding this comment.
Removed the enable/disable commands since they didn't work anyway. We don't create/import the planet4_dev database when running nro:install so the nro:disable command didn't work.
comzeradd
force-pushed
the
nro-install
branch
from
933f091 to
7caee09
Compare
comzeradd
force-pushed
the
nro-install
branch
from
7caee09 to
18ea224
Compare
Contributor
|
@comzeradd I'm on it! Running both installations |
GP-Dan-Tovbein
approved these changes
Dec 1, 2025
Contributor
GP-Dan-Tovbein
left a comment
GP-Dan-Tovbein
left a comment
There was a problem hiding this comment.
All good.
I've tested the p4 local env and Brasil's. The only inconvenient I had was related to a brasil's plugin but it's not related to this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our two installation scripts (
install.jsandnro-install.js) are 80% identical. That duplication makes maintenance harder, as several times in the past we had to duplicate a fix on both scripts.nro:installcommand to inform the community about the change.env:installcommand.Testing
npm run env:installnpm run env:install <nro-name>