Add git protocol variables for controlling how theme repos are cloned

[comzeradd]

Summary

To make it easy for switching git protocolo when hacing access to the theme repositories.

• NRO_GIT_PROTOCOL: for child themes. Set to ssh by default, as this is the most common scanario.
• GIT_PROTOCOL: for main theme. Set to https by default, as the most common scenario.

Both variables are set in .wp-env.override.json.

Testing

• On a fresh develop clone, adjust on .wp-env.overrride.json.dist those two above variables or test with their default values.
• On first env:install the .wp-env.override.json.dist file is copied over as .wp-env.override.json. So for repeating the test, you can either delete the last file, edit the dist file and re-run env:install or just edit .wp-env.override.json directly.
• Run env:install and env:install <nro> with different variations of those two variables, to test that the themes are cloned using the protocol selected by those two variables.
• Verify repo url by running git remote -v from within the theme.

[mardelnet]

@comzeradd, the testing instructions are not totally clear to me, for example:

• On a fresh develop clone, adjust .wp-env.overrride.json accordingly.
  • Can you specify how it should be adjusted?
• Run env:install and env:install <nro> with different settings.
  • What are those different settings?

[comzeradd]

@comzeradd, the testing instructions are not totally clear to me

I enriched the testing instructions to make them more clear 👍🏻

[mardelnet]

@comzeradd, the testing instructions are not totally clear to me

I enriched the testing instructions to make them more clear 👍🏻

Just to be clear, "On a fresh develop clone, adjust on .wp-env.overrride.json.dist those two above variables or test with their default values." means to edit NRO_GIT_PROTOCOL and GIT_PROTOCOL to use ssh or https and try all the possible combinations?

[comzeradd]

Just to be clear, "On a fresh develop clone, adjust on .wp-env.overrride.json.dist those two above variables or test with their default values." means to edit NRO_GIT_PROTOCOL and GIT_PROTOCOL to use ssh or https and try all the possible combinations?

Yes, exactly. Probably not needed to test all possible combinations, as the one variable doesn't affect the other.

[mardelnet]

@comzeradd
Your code changes look good to me.
I also performed the following tests, and in all cases the website was correctly installed locally:

Test 1:

• Environment: env:install
• NRO_GIT_PROTOCOL : ssh
• GIT_PROTOCOL : https

Test 2:

• Environment: env:install
• NRO_GIT_PROTOCOL : ssh
• GIT_PROTOCOL : ssh

Test 3:

• Environment: env:install chile
• NRO_GIT_PROTOCOL : https
• GIT_PROTOCOL : ssh

Test 4:

• Environment: env:install colombia
• NRO_GIT_PROTOCOL : https
• GIT_PROTOCOL : https