Lossless event delivery #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for lossless event delivery
Should not break, to avoid sending the event to just one of the subscribers.
Owner
|
A sticky event does not fulfill your use case? |
Author
|
It's not exactly the same use case, it's for the cases where I do not know that there are no listeners (yet). The only way I could do it, is to always use sticky events, and remove them as soon as the first listener receives it. Although I understand your doubts in merging, as it can cause the list of events to grow indefinitely if some event doesn't get a listener which can create a very tricky bug. |
Contributor
|
I recommend not merging this. This duplicates the sticky events functionality without adding anything new. Accomplishing what you are trying to do here would be to utilize sticky notifications, and your subscribers will still get the notifications after they initialize |
An event can now be: - Resubmitted and cancelled the equal running events - Resubmitted and ignored if that are equal running events - Cancelled when running
Conflicts: EventBus/src/de/greenrobot/event/EventBus.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for lossless event delivery
This way if the flag is set to true, the event is only delivered and deleted from the queue whenever a matching subscriber is registered.