BackgroudPoster can post thread more then one time #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outer try/catch block can break post logic. Steps: BG thread execute "return" inside synchronized block, but not execute finally block. So executorRunning is false. An other thread are in synchronized block of enqueue, check executorRunning (it is false) and make it true. Then BG thread execute finally section and changes executorRunning to false. So any other calls to enqueue will start this runnable again in executor. This pull request fixes this bug and restart thread if it ends by interrupt.
Owner
|
Is this something theoretical or did you experience this in practice? Interrupting a a thread will be hard in this scenario. Also, do you have a unit test for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outer try/catch block can break post logic.
Steps:
BG thread execute
"return" inside synchronized block, but not execute finally block. So
executorRunning is false.
An other thread are in synchronized block of
enqueue, check executorRunning (it is false) and make it true.
Then BG
thread execute finally section and changes executorRunning to false.
So
any other calls to enqueue will start this runnable again in
executor.
This pull request fixes this bug and restart thread if it ends
by interrupt.