Don't store note_list (a list of music21 Notes) in AnnVoice. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld improve diff performance, removing a completely unnecessary deepcopy of every Note in the score.
Owner
Author
|
I'm honestly not sure how much performance is gained, but I was breaking into the debugger during a long diff, and almost every time was in deepcopy of a Note/Rest. We were so careful to only use ids in annotated objects, but this one snuck past. No-one uses it, except as a temporary during init, so I just stopped putting it in self. It's just a variable in init now. |
Collaborator
|
Very good catch! I guess this will decrease the necessary memory a lot for long scores |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve diff performance, removing a completely unnecessary deepcopy of every Note in the score.