Tons of new detail in the diff. So much so that I added a DetailLevel parameter throughout. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. alignVertical).
Owner
Author
|
I am still working on this (API docs etc), but I'd like some opinions about how this looks so far. Please don't merge it yet. |
Owner
Author
|
OK, I think I've got it done now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail level can be set to GeneralNotesOnly, AllObjects (currently does "most" objects, but I'm working on it), and AllObjectsWithStyle, which includes things like object placement, text italic/bold/justification, object color, stem direction, etc, etc. For my use (when testing converter21), I like AllObjectsWithStyle, but I imagine most folks won't care about style too much, so the default detail level is AllObjects.