Fix docker-compile -o flag passed to docker instead of container#61
Merged
Conversation
The -o/--output flag was being placed before the image name in the docker run command, causing docker to interpret it as a docker flag rather than an argument for the container's entrypoint. Changes: - CLI: Place -o flag after image and sources - entrypoint.sh: Replace getopts with manual parsing to accept -o in any position (before or after sources) - Docs: Update examples to use more intuitive `src/*.bpf.c -o build/` ordering Fixes #60 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-o/--outputflag was passed as a docker argument instead of being passed to the container's entrypoint-oflag in any position (before or after sources)src/*.bpf.c -o build/orderingFixes #60
Test plan
tinybpf docker-compile -v --output dist/bpf/ tests/bpf/minimal.bpf.csrc/*.bpf.c -o build/✓-o build/ src/*.bpf.c✓🤖 Generated with Claude Code