Resolve crash on parsing timezone aware date time within DST transition gap #43
Merged
Resolve crash on parsing timezone aware date time within DST transition gap #43
Conversation
This function checks if the provided `DateTime` can be represented in the timezone without ambiguity, such as during daylight saving time transitions.
This function checks if the provided `DateTime` can be represented in the timezone without ambiguity, such as during daylight saving time transitions.
This function checks if the provided `DateTime` can be represented in the timezone without ambiguity, such as during daylight saving time transitions.
This function checks if the provided `DateTime` can be represented in the timezone without ambiguity, such as during daylight saving time transitions.
This function checks if the provided `DateTime` can be represented in the timezone without ambiguity, such as during daylight saving time transitions.
This function checks if the provided `DateTime` can be represented in the timezone without ambiguity, such as during daylight saving time transitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a crash when a date time property with a timezone specified and a date string within a DST transition is parsed. The current strategy is to validate against this and prompt the client to resubmit the property as either
UTCor adjusted DST adjusted.An example of this would be
DTSTART;TZID=Pacific/Auckland:20240929T020000which does not really exist as it's DST transitions toDTSTART;TZID=Pacific/Auckland:20240929T030000.In the future we can handle this better by making an assumption about the DST gap end time to proceed with. Ideally we we could lean on the
chrono_tzGapInfofacility introduced by this PR (chronotope/chrono-tz#188). Unfortunately this has not been included in a release yet and in an effort to keep things simple and stable for now we will proceed with this the validation strategy as we iron out other creases within the RediCal module.