Resolve query text parsing with brackets#49
Merged
Conversation
apexatoll
approved these changes
Jul 23, 2025
Collaborator
apexatoll
left a comment
apexatoll
left a comment
There was a problem hiding this comment.
Looks good to me!
Not 100% clear on the intricacies of the nom grammar rules, but happy that the tests cover this and the changes look like they've fixed the issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a bug parsing
TEXTsegments containing brackets within a query context.For example,
X-CATEGORIES:((TESTING)) CATEGORY,CATEGORY TWOshould be parsed as:((TESTING)) CATEGORYCATEGORY TWOInstead it returned an
eofparsing error.This is because of the query parsing context lookahead parser not being comprehensive enough in handling closing brackets.
This PR resolves this (albeit crudely).
Please review