Skip to content

Commit 17f5de9

Browse files
maciej-w-rozyckigregkh
authored andcommitted
MIPS: DEC: Remove do_IRQ() call indirection
[ Upstream commit 35554ea ] As from commit 8f99a16 ("MIPS: Tracing: Add IRQENTRY_EXIT section for MIPS") do_IRQ() is not a macro anymore and can be invoked directly from assembly code, as a tail call. Remove the dec_irq_dispatch() stub then and the indirection previously introduced with commit 187933f ("[MIPS] do_IRQ cleanup"), improving performance by reducing the number of control flow changes and the overall instruction count, while fixing a compiler's complaint about a missing prototype for said stub: arch/mips/dec/setup.c:780:25: warning: no previous prototype for 'dec_irq_dispatch' [-Wmissing-prototypes] 780 | asmlinkage unsigned int dec_irq_dispatch(unsigned int irq) | ^~~~~~~~~~~~~~~~ (which gets promoted to a compilation error with CONFIG_WERROR). Fixes: 8f99a16 ("MIPS: Tracing: Add IRQENTRY_EXIT section for MIPS") Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent f3d1b0c commit 17f5de9

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

arch/mips/dec/int-handler.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@
277277
srlv t3,t1,t2
278278

279279
handle_it:
280-
j dec_irq_dispatch
280+
j do_IRQ
281281
nop
282282

283283
#if defined(CONFIG_32BIT) && defined(CONFIG_MIPS_FP_SUPPORT)

arch/mips/dec/setup.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -776,9 +776,3 @@ void __init arch_init_irq(void)
776776
pr_err("Failed to register halt interrupt\n");
777777
}
778778
}
779-
780-
asmlinkage unsigned int dec_irq_dispatch(unsigned int irq)
781-
{
782-
do_IRQ(irq);
783-
return 0;
784-
}

0 commit comments

Comments
 (0)