Commit 1e45aa7
usb: xhci: Fix sleep in atomic context in xhci_free_streams()
commit 42c37c4 upstream.
When a USB device with active stream endpoints is disconnected,
xhci_free_streams() is called from the hub_event workqueue to
free the stream resources. It calls xhci_free_stream_info()
while holding xhci->lock with irqs disabled.
xhci_free_stream_info() invokes xhci_free_stream_ctx(), which
calls dma_free_coherent() for large stream context arrays.
dma_free_coherent() can sleep (e.g. via vunmap), triggering
a BUG when called from atomic context.
Call trace:
dma_free_attrs+0x174/0x220
xhci_free_stream_info+0xd0/0x11c
xhci_free_streams+0x278/0x37c
usb_free_streams+0x98/0xc0
usb_unbind_interface+0x1b8/0x2f8
device_release_driver_internal+0x1d4/0x2cc
device_release_driver+0x18/0x28
bus_remove_device+0x160/0x1a4
device_del+0x1ec/0x350
usb_disable_device+0x98/0x214
usb_disconnect+0xf0/0x35c
hub_event+0xab4/0x19ec
process_one_work+0x278/0x63c
Fix this by saving the stream_info pointers and clearing the
ep references under the lock, then calling xhci_free_stream_info()
outside the lock where sleeping is allowed.
Fixes: 8df75f4 ("USB: xhci: Add memory allocation for USB3 bulk streams.")
Cc: stable <stable@kernel.org>
Signed-off-by: Lianqin Hu <hulianqin@vivo.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://patch.msgid.link/20260703144033.483286-3-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>1 parent 48aeda9 commit 1e45aa7
1 file changed
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3723 | 3723 | | |
3724 | 3724 | | |
3725 | 3725 | | |
| 3726 | + | |
3726 | 3727 | | |
3727 | 3728 | | |
3728 | 3729 | | |
| |||
3783 | 3784 | | |
3784 | 3785 | | |
3785 | 3786 | | |
| 3787 | + | |
| 3788 | + | |
| 3789 | + | |
| 3790 | + | |
| 3791 | + | |
3786 | 3792 | | |
3787 | 3793 | | |
3788 | 3794 | | |
3789 | | - | |
| 3795 | + | |
3790 | 3796 | | |
3791 | 3797 | | |
3792 | 3798 | | |
| |||
3796 | 3802 | | |
3797 | 3803 | | |
3798 | 3804 | | |
| 3805 | + | |
| 3806 | + | |
| 3807 | + | |
3799 | 3808 | | |
3800 | 3809 | | |
3801 | 3810 | | |
| |||
0 commit comments