Skip to content

Commit 2dfe817

Browse files
Yang Wanggregkh
authored andcommitted
drm/amd/pm: remove trailing semicolon from AMDGPU_PM_POLICY_ATTR macro
[ Upstream commit 0d892af ] macros should not include a trailing semicolon as per kernel coding style (checkpatch.pl warning). move the semicolon from the macro definition to the invocation sites instead. checkpatch.pl logs: WARNING: macros should not use a trailing semicolon +#define AMDGPU_PM_POLICY_ATTR(_name, _id) \ + static struct amdgpu_pm_policy_attr pm_policy_attr_##_name = { \ + .dev_attr = __ATTR(_name, 0644, amdgpu_get_pm_policy_attr, \ + amdgpu_set_pm_policy_attr), \ + .id = PP_PM_POLICY_##_id, \ + }; Fixes: 4d154b1 ("drm/amd/pm: Add support for DPM policies") Signed-off-by: Yang Wang <kevinyang.wang@amd.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent afea00f commit 2dfe817

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/gpu/drm/amd/pm/amdgpu_pm.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2463,12 +2463,12 @@ static ssize_t amdgpu_set_pm_policy_attr(struct device *dev,
24632463
.dev_attr = __ATTR(_name, 0644, amdgpu_get_pm_policy_attr, \
24642464
amdgpu_set_pm_policy_attr), \
24652465
.id = PP_PM_POLICY_##_id, \
2466-
};
2466+
}
24672467

24682468
#define AMDGPU_PM_POLICY_ATTR_VAR(_name) pm_policy_attr_##_name.dev_attr.attr
24692469

2470-
AMDGPU_PM_POLICY_ATTR(soc_pstate, SOC_PSTATE)
2471-
AMDGPU_PM_POLICY_ATTR(xgmi_plpd, XGMI_PLPD)
2470+
AMDGPU_PM_POLICY_ATTR(soc_pstate, SOC_PSTATE);
2471+
AMDGPU_PM_POLICY_ATTR(xgmi_plpd, XGMI_PLPD);
24722472

24732473
static struct attribute *pm_policy_attrs[] = {
24742474
&AMDGPU_PM_POLICY_ATTR_VAR(soc_pstate),

0 commit comments

Comments
 (0)