x86/platform/olpc: xo15: Drop wakeup source on driver removal

rafaeljw · gregkh · commit 37b43903ef0f · 2026-07-24T16:03:14.000+02:00
[ Upstream commit cc96655 ] Prevent leaking a wakeup source object after removing the driver by adding appropriate cleanup code to its remove callback function. Fixes: a0f30f5 ("x86, olpc: Add XO-1.5 SCI driver") Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Link: https://patch.msgid.link/2069931.usQuhbGJ8B@rafael.j.wysocki Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/arch/x86/platform/olpc/olpc-xo15-sci.c b/arch/x86/platform/olpc/olpc-xo15-sci.c
@@ -185,6 +185,7 @@ static int xo15_sci_add(struct acpi_device *device)
 
 static void xo15_sci_remove(struct acpi_device *device)
 {
+	device_init_wakeup(&device->dev, false);
 	acpi_disable_gpe(NULL, xo15_sci_gpe);
 	acpi_remove_gpe_handler(NULL, xo15_sci_gpe, xo15_sci_gpe_handler);
 	cancel_work_sync(&sci_work);

Original file line number	Diff line number	Diff line change
`@@ -185,6 +185,7 @@ static int xo15_sci_add(struct acpi_device *device)`
`185`	`185`
`186`	`186`	`static void xo15_sci_remove(struct acpi_device *device)`
`187`	`187`	`{`
	`188`	`+ device_init_wakeup(&device->dev, false);`
`188`	`189`	`acpi_disable_gpe(NULL, xo15_sci_gpe);`
`189`	`190`	`acpi_remove_gpe_handler(NULL, xo15_sci_gpe, xo15_sci_gpe_handler);`
`190`	`191`	`cancel_work_sync(&sci_work);`