Skip to content

Commit 478a866

Browse files
sean-jcgregkh
authored andcommitted
iommu/amd: Fix a stale comment about which legacy mode is user visible
[ Upstream commit 4bf53c2 ] Update a stale comment about which of the legacy modes is visible to the user, i.e. can be forced via amd_iommu_intr=legacy. Fixes: b74aa02 ("iommu/amd: Fix legacy interrupt remapping for x2APIC-enabled system") Signed-off-by: Sean Christopherson <seanjc@google.com> Reviewed-by: Vasant Hegde <vasant.hegde@amd.com> Reviewed-by: Wei Wang <wei.w.wang@hotmail.com> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent b798ada commit 478a866

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

drivers/iommu/amd/amd_iommu_types.h

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -906,12 +906,13 @@ static inline int get_hpet_devid(int id)
906906
}
907907

908908
enum amd_iommu_intr_mode_type {
909-
AMD_IOMMU_GUEST_IR_LEGACY,
910-
911-
/* This mode is not visible to users. It is used when
912-
* we cannot fully enable vAPIC and fallback to only support
913-
* legacy interrupt remapping via 128-bit IRTE.
909+
/*
910+
* The legacy format mode is not visible to users to prevent the user
911+
* from crashing x2APIC systems, which for all intents and purposes
912+
* require 128-bit IRTEs. The legacy format will be forced as needed
913+
* when hardware doesn't support 128-bit IRTEs.
914914
*/
915+
AMD_IOMMU_GUEST_IR_LEGACY,
915916
AMD_IOMMU_GUEST_IR_LEGACY_GA,
916917
AMD_IOMMU_GUEST_IR_VAPIC,
917918
};

0 commit comments

Comments
 (0)