Skip to content

Commit 86cc450

Browse files
committed
nvmet-tcp: Do not WARN on remotely-controlled oversized SGL allocations
commit 737a3b5 upstream. When fuzzing the nvme target code, I tripped a kernel warning in nvmet_tcp_map_data() because the length passed into the allocator is controlled by the remote initiator. A remote initiator that sends a command with an SGL claiming a huge number, can create a scatterlist and iovec allocation of over 1 million entries, which causes the backing kmalloc call to exceed MAX_PAGE_ORDER and then the page allocator will trip on a WARN_ON_ONCE_GFP() message: WARNING: mm/page_alloc.c:5280 __alloc_frozen_pages_noprof Workqueue: nvmet_tcp_wq nvmet_tcp_io_work ... sgl_alloc_order nvmet_tcp_map_data nvmet_tcp_try_recv_pdu As it's never good to trip a kernel warning remotely due to many systems having panic-on-warn enabled, let's silence it by just add GFP_NOWARN to the allocation flags. Assisted-by: gkh_clanker_2000 Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Keith Busch <kbusch@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d094582 commit 86cc450

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

drivers/nvme/target/tcp.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,14 +428,15 @@ static int nvmet_tcp_map_data(struct nvmet_tcp_cmd *cmd)
428428
}
429429
cmd->req.transfer_len += len;
430430

431-
cmd->req.sg = sgl_alloc(len, GFP_KERNEL, &cmd->req.sg_cnt);
431+
cmd->req.sg = sgl_alloc(len, GFP_KERNEL | __GFP_NOWARN,
432+
&cmd->req.sg_cnt);
432433
if (!cmd->req.sg)
433434
return NVME_SC_INTERNAL;
434435
cmd->cur_sg = cmd->req.sg;
435436

436437
if (nvmet_tcp_has_data_in(cmd)) {
437438
cmd->iov = kmalloc_array(cmd->req.sg_cnt,
438-
sizeof(*cmd->iov), GFP_KERNEL);
439+
sizeof(*cmd->iov), GFP_KERNEL | __GFP_NOWARN);
439440
if (!cmd->iov)
440441
goto err;
441442
}

0 commit comments

Comments
 (0)